TestRootWrapping

[CAJan93]

What's changed and what's your intention?

eris.Wrapf(err, "failed to get user by email %s", email)
results in below, but the SQLSTATE 42703 should be root

{
    "external": "ERROR: column \"password\" does not exist (SQLSTATE 42703)",
    "root": {
        "code": "internal",
        "message": "failed to get user by email [email protected]"
    }
}

Checklist

• I have written the necessary docs and comments
• I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

[CAJan93]

@Gogomoe @Nebulazhang I think this is because we are creating regular errors instead of eris.Errorf. Do you think it makes sense to replace all the root errors with eris.statusError using eris.Errorf?

[Gogomoe]

Do you think it makes sense to replace all the root errors with eris.statusError using eris.Errorf?

We are able to create statusError by eris.Errorf(message).WithCode(eris.CodeNotFound)

[Gogomoe]

eris.Wrapf(err, "failed to get user by email %s", email)
results in below, but the SQLSTATE 42703 should be root

The message looks good to me. If an error is produced by external library and we warp it by eris.Wrap, we should focus on the external field.
If the error is entirely produced in our codes eris.New or eris.Errorf, then we should focus on the root

[CAJan93]

Fair enough @Gogomoe. I was just confused because the order in which the error are logged is not the one in which they are thrown.