Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reformat code and run dbt test on jaffle_shop #14

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

reformat code and run dbt test on jaffle_shop #14

wants to merge 4 commits into from

Conversation

neverchanje
Copy link
Contributor

@neverchanje neverchanje commented Dec 21, 2023 •
edited
Loading

This PR includes jaffle_shop in our repo so that we can customize the sql queries for more testing.

@neverchanje neverchanje requested a review from chenzl25 December 21, 2023 10:18
@neverchanje neverchanje marked this pull request as ready for review December 21, 2023 10:18
chenzl25
chenzl25 reviewed Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By directly including an external repository, we lose the ability to stay synchronized with upstream updates. In such cases, providing an external link alone is sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenzl25 chenzl25 chenzl25 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neverchanje @chenzl25