Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: return record output in run #219

Merged
merged 3 commits into from
Jun 25, 2024
Merged

refactor: return record output in run #219

merged 3 commits into from
Jun 25, 2024

Conversation

BugenZhao
Copy link
Collaborator

RecordOutput is now returned by Runner::run (or Runner::run_async). This allows users to access the output of each record, or check whether the record is skipped.

Signed-off-by: Bugen Zhao [email protected]

Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao requested a review from xxchan June 24, 2024 06:21
Signed-off-by: Bugen Zhao <[email protected]>
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

* runner: `RecordOutput` is now returned by `Runner::run` (or `Runner::run_async`). This allows users to access the output of each record, or check whether the record is skipped.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* runner: `RecordOutput` is now returned by `Runner::run` (or `Runner::run_async`). This allows users to access the output of each record, or check whether the record is skipped.
## [0.21.0] - 2024-06-25
* runner: `RecordOutput` is now returned by `Runner::run` (or `Runner::run_async`). This allows users to access the output of each record, or check whether the record is skipped.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. I was thinking to also include #217 and #218 in this breaking release. 😮

@BugenZhao BugenZhao merged commit 2441dff into main Jun 25, 2024
4 checks passed
@BugenZhao BugenZhao deleted the bz/run-return branch June 25, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants