Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support matching stdout for system #206

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Apr 11, 2024

No description provided.

xxchan added 2 commits April 8, 2024 11:11
fix clippy

test heredoc

Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
@xxchan xxchan marked this pull request as ready for review April 11, 2024 07:29
Copy link
Collaborator

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

#[error("process exited unsuccessfully: {0}")] // message from unstable `ExitStatusError`
struct SystemError(ExitStatus);
#[error("process exited unsuccessfully: {0}\nstdout: {1}\nstderr: {2}")]
struct SystemError(ExitStatus, String, String);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
struct SystemError(ExitStatus, String, String);
struct SystemError {
status: ExitStatus,
stdout: String,
stderr: String
};



# Note: when substitution is on, we need to escape the backslash
# Note: 1 blank line in the middle is ok, but not 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the system command really contain 2 consecutive blank lines? 😕

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ntfs

Signed-off-by: xxchan <[email protected]>
@xxchan xxchan enabled auto-merge (squash) April 11, 2024 08:47
Signed-off-by: xxchan <[email protected]>
@xxchan xxchan merged commit 38030ac into main Apr 11, 2024
4 checks passed
@xxchan xxchan deleted the xxchan/federal-haddock branch April 11, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants