Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runner): fix parallel testing db name duplication #198

Merged
merged 2 commits into from
Nov 1, 2023
Merged

fix(runner): fix parallel testing db name duplication #198

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32bc799
fix: fix parallel testing db name duplication, for the lib
stdrc Nov 1, 2023
746714c
fix
stdrc Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions sqllogictest/src/runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1023,11 +1023,9 @@ impl<D: AsyncDB, M: MakeConnection<Conn = D>> Runner<D, M> {
// for every slt file, we create a database against table conflict
let file = file.unwrap();
let db_name = file
.file_name()
.expect("not a valid filename")
.to_str()
.expect("not a UTF-8 filename");
let db_name = db_name.replace([' ', '.', '-'], "_");
.ok_or_else(|| anyhow!("not a UTF-8 filename"))?;
stdrc marked this conversation as resolved.
Show resolved Hide resolved
let db_name = db_name.replace([' ', '.', '-', '/'], "_");

self.conn
.run_default(&format!("CREATE DATABASE {db_name};"))
Expand Down
Loading