feat: run system commands #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Comment on lines
+125
to
135
| fn engine_name(&self) -> &str { | ||
| dispatch_engines!(self, e, { e.engine_name() }) | ||
| } | ||
|
|
||
| async fn sleep(dur: Duration) { | ||
| tokio::time::sleep(dur).await | ||
| } | ||
|
|
||
| async fn run_command(command: std::process::Command) -> std::io::Result<ExitStatus> { | ||
| Command::from(command).status().await | ||
| } |
There was a problem hiding this comment.
This is a breaking api change. Is it possible to make them default methods?
There was a problem hiding this comment.
It does have default implementations. However, new variants in RecordOutput and TestErrorKind still break the API. I guess we have to bump the major version.
liurenjie1024
approved these changes
Sep 14, 2023
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
|
Bump the version to v0.16.0 and also include the change log from #194. |
xxchan
approved these changes
Sep 15, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support running system commands in
sltfiles.Signed-off-by: Bugen Zhao [email protected]