Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove Internal node and add more system catalogs #832

Merged
merged 10 commits into from
Mar 11, 2024
Merged

refactor: remove Internal node and add more system catalogs #832

merged 10 commits into from
Mar 11, 2024

Conversation

wangrunji0408
Copy link
Member

@wangrunji0408 wangrunji0408 commented Feb 24, 2024 •
edited
Loading

  • remove Internal node from plan, merged into Scan node
  • replace InternalTableExecutor by SystemTableScanExecutor
  • add new system tables: pg_tables, pg_attribute and pg_stat
  • expand commands like \dt to scan from system tables
  • remove hardcoded contributor list, fetch from Github instead update contributor list

@wangrunji0408
remove internal node. rename 'internal schema' to 'system schema' a…
a6874e6 
…nd make its schema_id = 0

Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408
support more system tables
2c093a2 
Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408
update contributor list
bc04939 
Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408
cargo fmt
9df1ffc 
Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408
fix test
4355d36 
Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408
update slt
835e312 
Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408
cargo fmt
c976b52 
Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408 wangrunji0408 requested a review from xxchan March 4, 2024 09:08
skyzh
skyzh reviewed Mar 10, 2024
View reviewed changes
tests/sql/internal.slt Outdated Show resolved Hide resolved
@wangrunji0408 wangrunji0408 added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit ce4d4c6 Mar 11, 2024
4 checks passed
@wangrunji0408 wangrunji0408 deleted the wrj/system-catalog branch March 11, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

@TennyZhuang TennyZhuang Awaiting requested review from TennyZhuang

@xxchan xxchan Awaiting requested review from xxchan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangrunji0408 @skyzh