Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/catalog: add root test and fix doc #806

Merged
merged 3 commits into from
Nov 15, 2023
Merged

chore/catalog: add root test and fix doc #806

merged 3 commits into from
Nov 15, 2023

Conversation

caicancai
Copy link
Contributor

@caicancai caicancai commented Nov 15, 2023 •
edited
Loading

2023-11-15 14-59-24屏幕截图
Document description error

@caicancai
Copy link
Contributor Author

I also found some bugs with functions such as sum and am trying to fix them

wangrunji0408
wangrunji0408 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Previously we have the root-database-schema-table hierarchy. It seems too complex for an embedded database. So the "database" level was removed afterwards.

src/catalog/root.rs Show resolved Hide resolved
@wangrunji0408 wangrunji0408 added this pull request to the merge queue Nov 15, 2023
Merged via the queue into risinglightdb:main with commit 73b2c79 Nov 15, 2023
4 checks passed
@caicancai
Copy link
Contributor Author

谢谢！以前我们有 root-database-schema-table 层次结构。对于嵌入式数据库来说，这似乎太复杂了。因此，后来删除了“数据库”级别。

I also have such doubts here, thank you for the answer

@caicancai caicancai deleted the catalog branch November 21, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangrunji0408 wangrunji0408 wangrunji0408 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caicancai @wangrunji0408