chore/binder: throw err for other objectnames (#808)

* chore/binder: throw err for other objectnames Signed-off-by: caicancai <[email protected]> * chore/binder: throw err for other objectnames Signed-off-by: caicancai <[email protected]> --------- Signed-off-by: caicancai <[email protected]>
risinglightdb · Nov 17, 2023 · a5794ff · a5794ff
1 parent 73b2c79
commit a5794ff
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/binder/drop.rs b/src/binder/drop.rs
@@ -75,7 +75,7 @@ impl Binder {
                     cascade,
                 })))
             }
-            _ => todo!(),
+            _ => Err(BindError::UnsupportedObjectName(object_type)),
         }
     }
 }

diff --git a/src/binder/mod.rs b/src/binder/mod.rs
@@ -85,6 +85,8 @@ pub enum BindError {
     NotSupportedOnInternalTable,
     #[error("{0:?} is not an aggregate function")]
     NotAgg(String),
+    #[error("unsupported object name: {0:?}")]
+    UnsupportedObjectName(ObjectType),
     #[error("not supported yet: {0}")]
     Todo(String),
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -75,7 +75,7 @@ impl Binder { @@
                         cascade,
                     })))
                 }
-                _ => todo!(),
+                _ => Err(BindError::UnsupportedObjectName(object_type)),
             }
         }
     }
@@ Expand Down @@