Added support of Smepmp #601
Conversation
…smepmp. Sail function: haveSmepmp Added support of Smepmp Co-authored-by: William McSpaddden <[email protected]> Co-authored-by: Hamza Khan <[email protected]>
| } | ||
|
|
||
| register mseccfg : Mseccfg_ent | ||
| register mseccfgh : bits(32) |
There was a problem hiding this comment.
Normally we don't treat this as a separate register, we just make bitfield Mseccfg : bits(64) and then read/write the appropriate bits of it.
We have an implementation of mseccfg like that internally; I'll make a PR for it.
| /* Enable Smepmp */ | ||
| val sys_enable_smepmp = pure "sys_enable_smepmp" : unit -> bool | ||
| /* TODO: for extension smmpm and zkr to enable */ | ||
| function sys_has_mseccfg() -> bool = sys_enable_smepmp() |
There was a problem hiding this comment.
You can implement mseccfg even if you don't have any of the extensions that use it (and that isn't a weird edge case). So ideally this would be
// Callback to C
val sys_have_mseccfg : "sys_have_mseccfg" unit -> bool
function have_mseccfg() -> bool = sys_have_mseccfg() | sys_enable_smepmp() | sys_enable_zkr() ...
There was a problem hiding this comment.
You mean we need to add an extra command line parameter to act as an extra switch to control the presence of mseccfg to make sure that even if we don't implement extensions that use this register, we can still implement this register, right ?
There was a problem hiding this comment.
Yeah exactly. I don't think we need to actually bother hooking it up to a CLI arguments at the moment - we can wait until Alasdair's new config system exists and then it will be a whole lot less tedious. But we can just have a function that returns true as a placeholder so we don't forget.
| @@ -48,14 +48,43 @@ function pmpCheckRWX(ent, acc) = { | |||
| } | |||
| } | |||
|
|
|||
| // this needs to be called with the effective current privilege. | |||
| /* this needs to be called with the effective current privilege */ | |||
There was a problem hiding this comment.
// style comments are nicer IMO. I don't see why we would change them back?
There was a problem hiding this comment.
This is the part that was changed by @HamzaKh01, I didn't check this as I was too focused on the code implementation part, we can change it back if needed, but there are many one line comments like /* ... */ in Sail, we might need to declare it better in the codestyle after some discussion?
There was a problem hiding this comment.
Yeah there is an experimental auto-formatter in the Sail compiler but I don't know what state it got to and I'd guess it doesn't change this sort of thing.
|
So does someone review this code and merge it in? |
added command line support for Smepmp. command line switch: --enable-smepmp. Sail function: haveSmepmp
Added support of Smepmp
This pr was written by @HamzaKh01, merged with the command-line switch code provided by Bill, and adjusted by myself