-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dockerFile support #349
Conversation
Signed-off-by: Afonso Oliveira <[email protected]>
This worked well for me on mac. Only thing I had to do first was:
Because the After that I did the |
Excellent!
|
@dhower-qc I will contribute a GH Action to periodically build and push the image to Docker Hub. |
The answer to this
is my ignorance on the second part :) , but I'll modify it back.
I can surely do it. Actually, I've kind of already done this, the way I implemented it was by setting an environment variable and just
and then messed around a bit with the scripts under /bin. I'll push a new commit with what I've done so far, so you can review it and maybe then we can schedule a call and discuss how to do it? |
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
FYI: I messed up the last commits, I'm fixing it. |
Actually, this is working as is. Steps to run on wsl2 are simply
@dhower-qc anything you would like to see differently here? We can set up a call if you prefer! |
@dhower-qc can you please write how you want this docker or specify to be done? I understood it was though a config, but what would that flow look like? |
@AFOliveira take a look here: #351 I will update that PR this week. |
Thanks (or obrigado :) ) for the pointer, Rafael. I'll be paying attention to your PR. |
Signed-off-by: Derek Hower <[email protected]>
Signed-off-by: Derek Hower <[email protected]>
Signed-off-by: Derek Hower <[email protected]>
Signed-off-by: Derek Hower <[email protected]>
Signed-off-by: Derek Hower <[email protected]>
Signed-off-by: Derek Hower <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AFOliveira, I added a prompt if DOCKER/SINGULARITY env variables aren't present, and updated the regression accordingly. I also changed the Docker run command to map the UDB ROOT directly instead of $pwd (which all the scripts are assuming). Let me know if you see any issues. Otherwise, this is good to go.
Sorry for not understanding what you were asking in first place and thanks for the help on this :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested and all worked as supposed!
@dhower-qc github pages deployment failed, did I mess this up? |
Ah, thanks for noticing. I forgot to update pages.yaml to pick a container, so it's just stuck at the prompt asking docker/singularity. I'll push a fix. |
As discussed on last meeting that dockerfile could ease user interaction with the UDB, I came up with this dockerfile which runs with the following:
sudo docker build -t udb -f .devcontainer/Dockerfile .
sudo docker run -it -v $(pwd):/workspace -w /workspace udb bash
I could add an environment variable to ensure easier interaction with ./do since I have not touched that part.