Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit to container height #52

Conversation

jaredleishman
Copy link

@jaredleishman jaredleishman commented Jan 30, 2020

#9

@rikschennink
Copy link
Owner

Thanks! Will test this as soon as possible.

@rikschennink
Copy link
Owner

Hi, how will this work? Will it upscale text so it fits fixed height containers? And how does it deal with wrapping text? Can you create a public test case so I can take a quicker look.

@jaredleishman
Copy link
Author

I will make a test case. You bring up a good point though. I'm not sure if this will work with text wrapping. I'll have to think about that more.

@rikschennink
Copy link
Owner

@iamjleishman Thanks! 👍😊

@davwheat
Copy link

davwheat commented Apr 6, 2020

I've found that this doesn't scale the text as much as it can, or sometimes too much (the question marks). Each of the spans are equal height.

@jaredleishman
Copy link
Author

@davwheat I think you're right. I don't think this solution will actually work. I got really busy after making this PR so I haven't come back to look at it. I think I will close this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants