Support CCL #74
Merged
Support CCL #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleby
reviewed
Jun 17, 2019
ecpeterson
reviewed
Jun 20, 2019
ecpeterson
approved these changes
Jun 20, 2019
|
I just double-checked: there's a |
OK. Hold off on merging, and I'll do that. |
appleby
reviewed
Jun 20, 2019
stylewarning
suggested changes
Jun 20, 2019
with-unique-rpc-address macro for tests declaim special *mocked-namespace* silence warnings if slee-p then sleep Fix with-unique-rpc-address Actually make the address unique :list now maps to type vector (not simple-vector) See #72 (comment) Explicitly wait for server thread to terminate It is my understanding that bt:destroy-thread does not make a guarantee about *when* a thread will be destroyed, only that the destroy signal has been delivered. Or something like that. This does seem hacky. declaim *mocked-namespace* in the correct location Explicitly wait for thread to be destroyed in tests (fixes CCL) On non-CCL use the previous method of just `(bt:destroy-thread server-thread)` redundant concatenate -> format Comment grammar export with-unique-rpc-address from rpcq package Test serialize/deserialize messages with lists Docstring for with-unique-rpc-address Leave FIXME note regarding thread killers array-total-size -> length fix
stylewarning
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes here are:
defclass's slots, unless you have(debug 3).bt:destroy-threaddoes not appear to immediately destroy a thread. I think the behaviour ofdestroy-threadis implementation-dependent. To keep CCL happy, I explicitly loop until the thread is dead proper. If you don't do this, the threads hang around and you get very frustration and incomprehensible errors that you will spend you weekend trying to understand.There are peculiarities of threading that I don't understand. I don't suppose this is the best solution, but it's the best I have for now.
Closes #72.