Add helm-chart (#14)

[dromaniuk]

Hi. I've added simple helm chart. It makes available to deploy it to Kubernetes with Prometheus Operator compatibility (Config is being declared as Probes).

I've checked it on Kubernetes 1.19

[ribbybibby]

Why are these (and the resources below) commented out? As an example?

[dromaniuk]

As example.
I didn't dive deep into securityContext, for now.
Perhaps you'll advise better default value for the parameter?

[ribbybibby]

Suggested change

	# fsGroup: 1001
	# runAsGroup: 1001
	# runAsNonRoot: true
	# runAsUser: 1001
	fsGroup: 100
	runAsGroup: 100
	runAsNonRoot: true
	runAsUser: 100

The image runs as user 100 by default, so let's go with that.

[ribbybibby]

Thanks for this! It looks good overall, I've just left a couple of comments.

One thing I think that should be added is a way to add configMap and secret volumes + volumeMounts so that users can provide the config file and mount certificates in the exporter container.

[dromaniuk]

One thing I think that should be added is a way to add configMap and secret volumes + volumeMounts so that users can provide the config file and mount certificates in the exporter container.

I've added configMap generation in 546a1c4
The rest whould be better to implement later as chart improvements.
They take quite more time, than I expected. So I propose to apply this pull-request for the beginning, and "polish" the chart next time.

[dromaniuk]

Any updates? Seems the pull-request has been forgotten

[ribbybibby]

Sorry @dromaniuk, I haven't had much time to dedicate to this project recently.

Could you please add the ability to mount secrets as requested? This is a very common requirement for people using their own PKI or client authentication and I would prefer that the chart had that functionality. My concern is that if it's left til 'next time', that 'next time' isn't going to come around.

[etiennejournet]

Hi @dromaniuk, thanks for your work, I can help you on this if you don't have time. Have you considered adding the proper rbac template to allow for monitoring secrets inside of the same cluster the container is deployed in ?

[dromaniuk]

Hi @dromaniuk, thanks for your work, I can help you on this if you don't have time. Have you considered adding the proper rbac template to allow for monitoring secrets inside of the same cluster the container is deployed in ?

@etiennejournet I will be very grateful for your help.

[etiennejournet]

Hey, I have no time for now but keeping this in mind. I'll come back to you asap