tpm: Boot with a warning if the event log is full #657
Conversation
|
Yeah, I'd like to see it logged once. Otherwise this looks reasonable. |
kukrimate
force-pushed
the
main
branch
2 times, most recently
from
b48ac61 to
b6a284a
Compare
The extend operation still occurs even if `*_log_extend_event` returns EFI_VOLUME_FULL. Let's print a warning when we first see this error code, but otherwise continue booting. Bailing on this condition has caused machines with limited event log space to become unbootable with TPM 2.0 enabled. (fixes rhboot#654) Signed-off-by: Mate Kukri <[email protected]>
|
@vathpela Added the warning, and it should cover all places the EFI_VOLUME_FULL thing can be returned to represent this condition. |
kukrimate
changed the title
|
@kukrimate in https://bugs.launchpad.net/ubuntu/+source/shim/+bug/2089320 you mentioned this should solve it. Any chance this can get merged? |
|
I ran into this recently, when coincidentally, I enabled TPM2.0 and updated Windows 10 in a dual boot configuration. I presumed that it was the SBAT issue, exacerbated by the Asus X99 UEFI refusing to work with Mokutil. It had been working well for a very long time prior to that, rarely running W10. On closer examination of this issue and some related reports, I'm certain this is it. It appears MSFT not to blame. Will build and confirm, but hopefully, this will make life easier and get into distribution soon. |
The extend operation still occurs even if
*_log_extend_eventreturns EFI_VOLUME_FULL.
Let's print a warning when we first see this error code, but otherwise
continue booting.
Bailing on this condition has caused machines with limited event log
space to become unbootable with TPM 2.0 enabled. (fixes #654)