Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reviewdog command line argument changes (--fail-level) #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nayuta
Copy link
Contributor

@nayuta nayuta commented Dec 22, 2024

Support reviewdog command line argument changes.

New: support fail-level
Deprecated: fail-on-error

See: #70
See also: https://github.com/reviewdog/reviewdog/blob/master/CHANGELOG.md#rotating_light-deprecation-warnings

@nayuta nayuta self-assigned this Dec 22, 2024
@nayuta nayuta marked this pull request as draft December 22, 2024 06:15
@nayuta nayuta changed the title Support reviewdog command line argument changes Support reviewdog command line argument changes (fail-level) Dec 22, 2024
@nayuta nayuta changed the title Support reviewdog command line argument changes (fail-level) Support reviewdog command line argument changes (--fail-level) Dec 22, 2024
@nayuta nayuta force-pushed the support_reviewdog_parameter_changes branch from a324957 to 091455a Compare December 22, 2024 06:34
@nayuta nayuta marked this pull request as ready for review December 22, 2024 06:35
@nayuta nayuta requested review from haya14busa and shmokmt December 22, 2024 06:36
Exit code for reviewdog when errors are found [true,false]
Default is `false`.
default: 'false'
required: false
deprecated: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecated is invalid.
Please use deprecationMessage instead of it.

Suggested change
deprecated: true
deprecationMessage: Deprecated, use `fail_level` instead.

see also.

Comment on lines +39 to +42
description: |
The level of failures that will cause the action to fail [any,info,warning,error]
Default is error.
default: ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to keep the default value the same as reviewdog. what do you think?

Suggested change
description: |
The level of failures that will cause the action to fail [any,info,warning,error]
Default is error.
default: ''
description: |
If set to `none`, always use exit code 0 for reviewdog. Otherwise, exit code 1 for reviewdog if it finds at least 1 issue with severity greater than or equal to the given level. Possible values: [none,any,info,warning,error] Default is `none`.
default: 'none'

see also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants