Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/Tending dependencies #198

Merged
merged 4 commits into from
Dec 9, 2023

Conversation

blast-hardcheese
Copy link
Collaborator

Why

Without the mypy upgrade, ast27/Custom/../Include/compile.h:5:10: fatal error: code.h: No such file or directory prevents dependencies from being installed. Turns out it's because typed-ast is no longer maintained, in favor of relying on a modern ast shipped with Python.

What changed

  • Bump mypy
  • Sort sphinx deps (we had it in there twice)
  • poetry setup may have done something in the past, it does nothing now. poetry install in README.md.

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner December 9, 2023 01:30
@blast-hardcheese blast-hardcheese requested review from cdmistman and removed request for a team December 9, 2023 01:30
Copy link
Collaborator

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@blast-hardcheese blast-hardcheese merged commit 28a8941 into master Dec 9, 2023
5 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/chore/tending-dependencies branch December 9, 2023 01:37
@blast-hardcheese blast-hardcheese added the chore Incidental change that should not impact released library label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Incidental change that should not impact released library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants