Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: simplify exec mock #16698

Merged
merged 2 commits into from
Jul 22, 2022
Merged

test: simplify exec mock #16698

merged 2 commits into from
Jul 22, 2022

Conversation

viceice
Copy link
Member

@viceice viceice commented Jul 22, 2022

Changes

simplify exec mocking

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from JamieMagee and rarkins July 22, 2022 07:05
@viceice viceice mentioned this pull request Jul 22, 2022
Merged
6 tasks
@viceice viceice enabled auto-merge (squash) July 22, 2022 07:12
@zharinov zharinov self-requested a review July 22, 2022 07:14
@viceice viceice merged commit 6c78237 into main Jul 22, 2022
@viceice viceice deleted the test/better-exec-mock branch July 22, 2022 07:42
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.122.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@zharinov zharinov zharinov approved these changes

@JamieMagee JamieMagee Awaiting requested review from JamieMagee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viceice @renovate-release @zharinov @rarkins