[#649] Add stm32h7 pwr peripheral and rcc/syscfg updates #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the STM32H7_PWR peripheral.
This commit adds some missing RCC registers causing panics in the stm32h7xx-hal.
This commits adds the missing CompensationCellControl register which is polled by the stm32h7xx-hal at startup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This PR fixes the major issues I've encountered when trying to bring up an application based on the Rust stm32hxx-hal package, renode/renode#649. The RCC and SYSCFG peripherals have just been updated with some missing registers while I've added the
STM32H7_PWRperipheral but I've also seen some similar work in tickets opened by @RallySmith, copied here for info.A few questions:
READYflag of bit 8. The STM user manual states that this is driven high in response to the CSION flag being set in the RCC_CR register. I've just assigned this totrue. Is this okay or do I need to somehow pol the RCC register value?STM32H7_PWRperipheral was created by copying theSTM32WBA_PWRperipheral and modifying it. The registers are correct but I've not implemented all the AVD functionality to match what was there for PVD. For example, you seem to have methods that allow overriding of the voltage from a test? https://github.com/renode/renode-infrastructure/blob/master/src/Emulator/Peripherals/Peripherals/Miscellaneous/STM32WBA_PWR.cs#L37 Is that correct or is there another use of this method? Should I be replicating the same functionality and threshold generation for the analog domain?