Skip to content

state: caching: order-cache: Build new filter-based cache interface (… #4115

state: caching: order-cache: Build new filter-based cache interface (…

state: caching: order-cache: Build new filter-based cache interface (… #4115

GitHub Actions / clippy failed Dec 21, 2024 in 0s

clippy

4 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 4
Warning 0
Note 0
Help 0

Versions

  • rustc 1.82.0-nightly (a7399ba69 2024-08-31)
  • cargo 1.82.0-nightly (8f40fc59f 2024-08-21)
  • clippy 0.1.82 (a7399ba 2024-08-31)

Annotations

Check failure on line 366 in state/src/interface/order_book.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

associated function `is_task_queue_free` is never used

error: associated function `is_task_queue_free` is never used
   --> state/src/interface/order_book.rs:366:8
    |
363 | impl StateInner {
    | --------------- associated function in this implementation
...
366 |     fn is_task_queue_free<T: TransactionKind>(
    |        ^^^^^^^^^^^^^^^^^^

Check failure on line 119 in state/src/interface/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `order_cache` is never read

error: field `order_cache` is never read
   --> state/src/interface/mod.rs:119:16
    |
115 | pub struct StateInner {
    |            ---------- field in this struct
...
119 |     pub(crate) order_cache: Arc<OrderBookCache>,
    |                ^^^^^^^^^^^
    |
    = note: `StateInner` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
    = note: `-D dead-code` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(dead_code)]`

Check failure on line 93 in state/src/applicator/order_book.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `order_info`

error: unused variable: `order_info`
  --> state/src/applicator/order_book.rs:93:13
   |
93 |         let order_info = tx
   |             ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_order_info`
   |
   = note: `-D unused-variables` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_variables)]`

Check failure on line 104 in state/src/applicator/order_book.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unreachable statement

error: unreachable statement
   --> state/src/applicator/order_book.rs:101:9
    |
99  |           todo!("re-implement write paths for order book cache");
    |           ------------------------------------------------------ any code following this expression is unreachable
100 |           // self.order_cache().add_matchable_order_blocking(order_id);
101 | /         self.system_bus().publish(
102 | |             ORDER_STATE_CHANGE_TOPIC.to_string(),
103 | |             SystemBusMessage::OrderStateChange { order: order_info },
104 | |         );
    | |__________^ unreachable statement
    |
    = note: `-D unreachable-code` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unreachable_code)]`