Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

state: interface: Use new order book cache in interface methods #875

Merged
merged 1 commit into from
Dec 22, 2024
Merged

state: interface: Use new order book cache in interface methods #875

merged 1 commit into from
Dec 22, 2024

Conversation

joeykraut
Copy link
Member

@joeykraut joeykraut commented Dec 22, 2024 •
edited
Loading

Purpose

This PR adds back in write paths for the order book cache and uses the new order book cache in the state interface. This involves two caller locations:

  • The admin API, which roughly just uses renamed methods
  • The matching engine, which now constructs an order book filter based on the order it is trying to match

Testing

  • Unit tests pass
  • Testing in testnet with various match flows

@joeykraut joeykraut force-pushed the joey/new-match-cache-writes branch from 84d1467 to fa9dfec Compare December 22, 2024 00:49
@joeykraut joeykraut requested a review from akirillo December 22, 2024 00:53
@joeykraut joeykraut marked this pull request as ready for review December 22, 2024 00:53
akirillo
akirillo approved these changes Dec 22, 2024
View reviewed changes
common/src/types/wallet/balances.rs Outdated Show resolved Hide resolved
state/src/caching/order_metadata_index.rs Show resolved Hide resolved
state/src/replication/state_machine/snapshot.rs Show resolved Hide resolved
@joeykraut joeykraut force-pushed the joey/new-match-cache-writes branch from fa9dfec to b6cb0f5 Compare December 22, 2024 01:32
@joeykraut joeykraut merged commit ec0363c into joey/new-order-cache Dec 22, 2024
2 of 3 checks passed
@joeykraut joeykraut deleted the joey/new-match-cache-writes branch December 22, 2024 01:33
joeykraut added a commit that referenced this pull request Dec 22, 2024
@joeykraut
state: interface: Use new order book cache in interface methods (#875)
dc81a46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akirillo akirillo akirillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeykraut @akirillo