workers: job-types, state: applicator: emit task completion events #874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
TaskCompletion
event type, representing the completion of a task (successful or not). This will be used to index task history, and as such it is basically a wrapper around theHistoricalTask
type. This event gets emitted in the state applicator in the same code path where we record historical tasks. As such, we check that the local peer is the executor of the task before emitting the event, to prevent duplicate event emission across the cluster.Testing