Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circuits: valid-commitments: Allow relayer fees below max_match_fee #867

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

joeykraut
Copy link
Member

Purpose

This PR updates VALID COMMITMENTS so that the relayer may charge a match fee lower than a wallet's configured max_match_fee; rather than being constrained to charge exactly the match_fee.

Testing

  • Unit tests pass, added a test for a lower fee, and modified an existing test to be one fixed-point tick above the maximum
  • Test in testnet after regenerating vkeys

@joeykraut joeykraut marked this pull request as ready for review December 19, 2024 21:40
@joeykraut joeykraut requested a review from akirillo December 19, 2024 21:40
@joeykraut joeykraut force-pushed the joey/max-relayer-fee branch from 94d9bbf to a4bc7d1 Compare December 19, 2024 23:46
@joeykraut joeykraut merged commit 8b1c09d into main Dec 19, 2024
2 of 3 checks passed
@joeykraut joeykraut deleted the joey/max-relayer-fee branch December 19, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants