external-api: external_match: add get_quote_amount helper
#862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehyunc
changed the title
get_quote_amount helper
2 tasks
joeykraut
approved these changes
Dec 16, 2024
| /// | ||
| /// The price here is expected to be decimal corrected; i.e. multiplied by | ||
| /// the decimal diff for the two tokens | ||
| pub fn get_quote_amount(&self, price: FixedPoint) -> Amount { |
There was a problem hiding this comment.
will you move this to be co-located with get_base_amount above, and make get_base_amount public?
sehyunc
force-pushed
the
sehyun/add-get-quote-amount
branch
from
4e1e32d to
209450c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds a
get_quote_amounthelper to precisely calculate the implied quote amount given a decimal corrected price.Testing