node-support: event-export-sidecar: create event export sidecar #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirillo
force-pushed
the
andrew/event-export
branch
from
b6c181c to
9cdcc7f
Compare
Base automatically changed from
andrew/event-export
to
andrew/event-ingestion
December 12, 2024 18:20
akirillo
force-pushed
the
andrew/event-ingestion
branch
from
7fea938 to
a7249d0
Compare
Base automatically changed from
andrew/event-ingestion
to
andrew/event-manager-phase-1
December 12, 2024 18:42
akirillo
force-pushed
the
andrew/event-export-sidecar
branch
from
df29dba to
c61118c
Compare
akirillo
force-pushed
the
andrew/event-export-sidecar
branch
2 times, most recently
from
6df9c78 to
ea0ae46
Compare
joeykraut
approved these changes
Dec 12, 2024
…t sidecar in bootloader
akirillo
force-pushed
the
andrew/event-export-sidecar
branch
from
ea0ae46 to
a510475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
node-supportdaemon responsible for re-exporting events from the relayer to the historical state engine. It establishes the Unix socket the relayer exports events to, listens for events on this socket, and submits them to the HSE.As a part of these changes, I swapped the
Multiaddrevent_export_addrconfig option for aUrl-based one. This was due to parsing issues with Unix multiaddrs - it interprets/as a protocol delimiter so only sibling paths could be used for a socket. URLs capture the same flexibility that we need between HTTP and Unix addresses with better parsing.Testing:
I tested this with a local relayer / sidecar / HSE / DB with the following flow: create wallet, deposit, place order, match, withdraw (and on one of the wallets, cancel order).