circuits: integration: Simplify integration tests #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirillo
approved these changes
Nov 24, 2023
joeykraut
force-pushed
the
joey/match-tests
branch
from
1e36d44 to
b08fb3d
Compare
These tests are moved from the integration tests, they belong better as unit tests for testing circuit boundary cases.
This removes many unnecessary integration tests in light of the mocking framework for MPC gadgets -- which has allowed most tests to be moved into unit tests where they belond. Integration tests will be reserved for connecting circuits and end-to -end functionality.
joeykraut
force-pushed
the
joey/circuits-integration-tests
branch
from
2cdbee6 to
96c8d54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR removes many unnecessary integration tests in light of the mocking framework for MPC gadgets -- which has allowed most tests to be moved into unit tests where they belong.
Integration tests will be reserved for connecting circuits and end-to-end functionality. To that end, this PR reserves the
matchintegration test. This will be augmented by a test for the settlement MPC circuit and the end-to-end collaborative proof.Testing