Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circuits: zk-circuits: valid-match-settle: Add settlement tests #265

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

joeykraut
Copy link
Member

Purpose

This PR refactors the VALID SETTLE unit tests into the VALID MATCH SETTLE tests. This PR also removes valid-settle from the repo as this circuit is now part of VALID MATCH SETTLE.

Testing

  • All unit tests pass

@joeykraut joeykraut marked this pull request as ready for review November 23, 2023 01:41
@joeykraut joeykraut requested a review from akirillo November 23, 2023 01:41
@joeykraut joeykraut force-pushed the joey/merge-match-settle branch from dea2be8 to e5e7a3e Compare November 25, 2023 23:11
Base automatically changed from joey/merge-match-settle to joey/circuits-refactor November 25, 2023 23:11
@joeykraut joeykraut force-pushed the joey/match-settle-tests branch from 789de32 to 3d90b57 Compare November 25, 2023 23:13
@joeykraut joeykraut merged commit ff25d92 into joey/circuits-refactor Nov 25, 2023
1 of 3 checks passed
@joeykraut joeykraut deleted the joey/match-settle-tests branch November 25, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants