circuits: zk-circuits: valid-match-mpc: Refactor over mpc-plonk
#262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeykraut
commented
Nov 21, 2023
Comment on lines
-315
to
-318
| // Ensure all orders have boolean side | ||
| for order in new_wallet.orders.iter() { | ||
| cs.enforce_bool(order.side)?; | ||
| } |
There was a problem hiding this comment.
Changing the type of Order::side to be boolean means this constraint is automatically generated when the type is allocated
joeykraut
commented
Nov 21, 2023
Comment on lines
-132
to
-141
| // Constrain the min_amount_order_index to be binary | ||
| // i.e. 0 === min_amount_order_index * (1 - min_amount_order_index) | ||
| let (_, _, mul_out) = cs | ||
| .multiply( | ||
| &witness.match_res.min_amount_order_index.clone().into(), | ||
| &(MpcLinearCombination::from_scalar(Scalar::one(), fabric.clone()) | ||
| - &witness.match_res.min_amount_order_index), | ||
| ) | ||
| .map_err(ProverError::Collaborative)?; | ||
| cs.constrain(mul_out.into()); |
There was a problem hiding this comment.
same here, changing the type to bool automatically generates this constraint
joeykraut
force-pushed
the
joey/valid-match-refactor
branch
from
66bd583 to
9b13760
Compare
akirillo
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR refactors the
VALID MATCH MPCcircuit over thempc-plonksystem. This method proves validity of a match that results from an MPC or the internal matching engine.Note that we intend to combine this circuit with
VALID SETTLE, this will come in a follow up PR.Also deferred to a follow up are more extensive unit tests -- this circuit is tested heavily in integration tests, but given the new mocking interface for MPCs, it makes sense to test them in unit as well.
Testing