arbitrum-client: fetch_public_shares_from_tx #261
Merged
+181
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirillo
force-pushed
the
andrew/calldata-parsing
branch
from
e312094 to
79db48d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
fetch_public_shares_from_txmethod to the Arbitrum client, allowing it to read a wallet's public secret shares from calldata.Currently, this method only expects to parse shares from calldata where the {
new_wallet,update_wallet,process_match_settle} call was a top-level call issued by an EOA, for simplicity. I've added a todo for parsing shares from calldata where the Darkpool function was called by another contract, I felt it was not worth trying to implement before having an integration testing stack.This marks the end of the core functionality required by the client, the next PRs will focus on integration testing of the client, after which I'll focus on deprecating the Starknet client throughout the relayer in favor of the Arbitrum client.