plonk: multiprover: multiprover-kzg: Add batch commit and open methods #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirillo
approved these changes
Oct 14, 2023
| @@ -117,6 +117,7 @@ where | |||
| // | Commitment Scheme Implementation | | |||
| // ------------------------------------ | |||
|
|
|||
| // TODO: Implement a more efficient batching scheme | |||
There was a problem hiding this comment.
It looks like even Jellyfish hasn't implemented the batched version of their KZG scheme as described in https://eprint.iacr.org/2020/1536, this will be fun to crack into later on, lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR implements batched analogs of the commit and open methods to provide a convenient PCS interface for many polynomials. Note that prover side the batching is dead simple: just commit individually to each polynomial and open at a different point. This matches the single-prover implementation which only combines the commitments verifier-side
Testing
UnivariateKzgPCS::batch_verifymethod