Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CN-exec] Runtime loop invariants #723

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

[CN-exec] Runtime loop invariants #723

wants to merge 16 commits into from

Conversation

rbanerjee20
Copy link
Contributor

No description provided.

@rbanerjee20 rbanerjee20 requested review from cp526 and dc-mak November 20, 2024 18:44
@rbanerjee20 rbanerjee20 mentioned this pull request Nov 20, 2024
Closed
dc-mak
dc-mak reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@dc-mak dc-mak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t comment on the specifics but left a few nits. Do you have any tests to include with this change, demonstrating loops working?

backend/cn/lib/cn_internal_to_ail.ml Outdated Show resolved Hide resolved
backend/cn/lib/cn_internal_to_ail.ml Outdated Show resolved Hide resolved
backend/cn/lib/cn_internal_to_ail.ml Outdated Show resolved Hide resolved
backend/cn/lib/executable_spec_internal.ml Show resolved Hide resolved
backend/cn/lib/executable_spec_internal.ml
| [ _ ] -> []
| x :: xs -> x :: remove_last xs
in
let rec remove_last_semicolon = function
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems amenable to regexps

backend/cn/lib/executable_spec_utils.ml Show resolved Hide resolved
backend/cn/lib/executable_spec_utils.ml Show resolved Hide resolved
backend/cn/lib/ownership_exec.ml Outdated Show resolved Hide resolved
@rbanerjee20
Copy link
Contributor Author

Can’t comment on the specifics but left a few nits. Do you have any tests to include with this change, demonstrating loops working?

I haven't written any new tests but am checking that the previous CI tests that had loop invariants (which was a no-op in runtime testing before) are still working with these new added checks

@rbanerjee20 rbanerjee20 marked this pull request as ready for review November 22, 2024 01:05
@ZippeyKeys12 ZippeyKeys12 mentioned this pull request Dec 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dc-mak dc-mak dc-mak left review comments

@cp526 cp526 Awaiting requested review from cp526

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbanerjee20 @dc-mak