templates: update CacheStorage
type reference
#10316
Open
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The type of caches references
CacheStorage
fromlib.dom.d.ts
, but this is incompatible with the actual implementation on the Cloudflare network.The first one is from
lib.dom.d.ts
, and the other is from@cloudflare/workers-types
.This is because "DOM" is specified as the
lib
intsconfig.json
, which is correct in itself, but some adjustments are needed.Solution
I think there are two approaches. [Source for the fix]
First, import and declare
CacheStorage
type from@cloudflare/workers-types
in the file where caches is defined.Second, separate the
tsconfig.json
forserver.ts
and theapp
folder. While this approach allows for more accurate types, it makes the project more complicated.If you handle the server outside of Remix (e.g. Remix + Hono), the second approach is better. However, the first approach works well in most cases.