Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: adjust entry.server for single fetch #10240

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Aleuck
Copy link

@Aleuck Aleuck commented Nov 18, 2024

I noticed that the templates for create-remix have been updated to have v3_singleFetch enabled by default but didn't update the entry.server code to match what is recommended on the docs.

This caused a bit of confusion for me as I didn't understand there was a new export key for the stream timeout.

Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 80a1ef6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 18, 2024

Hi @Aleuck,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@Aleuck Aleuck force-pushed the template-remix-single-fetch branch from 7e50ca8 to 646048d Compare November 18, 2024 18:53
@Aleuck Aleuck force-pushed the template-remix-single-fetch branch from 646048d to c6249ac Compare November 18, 2024 18:53
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 18, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

chrzrdx added a commit to chrzrdx/reoserv.net that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants