-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Vite to the Indie Stack #284
base: main
Are you sure you want to change the base?
Conversation
Sync with remix-run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @shmuli9. Just curious why we change .js to .cjs? We did say "type": "module" in package.json I would have thought js will be treated as mjs? Did I miss anything? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@enRose I can't actually remember the exact reason why this was necessary. Pretty sure it was because eslint doesn't support esm.
If you've applied these changes do you want to check that it works ok as .js?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shmuli9 I think you are right. Ran it as .js says require() not supported. I wonder if v9 of eslint would actually work with .js.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, pretty sure eslint v9 supports esm natively.
You can see here that for v8.57,.cjs
is required
I have applied these changes as well to my indie stack and it works! Thanks @shmuli9 |
ts-node
and replace withvite-node
for simpler ESM support