Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add remark-semantic-blockquotes to list of plugins #1370

Closed
wants to merge 1 commit into from

Conversation

NikitaRevenco
Copy link

@NikitaRevenco NikitaRevenco commented Sep 25, 2024

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

I made this plugin which transforms this

> Better to admit you walked through the wrong door than spend your life in the wrong room.
>
> @ [Josh Davis](https://somewhere.com)

Into this

<figure data-blockquote-figure="">
  <blockquote data-blockquote-content="">
    Better to admit you walked through the wrong door than spend your life in
    the wrong room.
  </blockquote>
  <figcaption data-blockquote-figcaption="">
    [Josh Davis](https://somewhere.com)
  </figcaption>
</figure>

Explanation: https://github.com/nikitarevenco/remark-semantic-blockquotes?tab=readme-ov-file#when-should-i-use-this
Inspiration: https://css-tricks.com/quoting-in-html-quotations-citations-and-blockquotes/

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 25, 2024
@wooorm
Copy link
Member

wooorm commented Sep 25, 2024

Heya! Cool project :)

This is not something that should be a remark plugin. This should be a rehype plugin.
You don’t care about generating > # stuff like *this* (which is markdown syntax). You care about generating <figure><blockquote><p>stuff like <em>this</em></blockquote></figure> (which is HTML).

See https://github.com/remarkjs/remark-rehype for more info. Feel free to open a discussion to ask us for help. A PR to the similar rehype list to share your improved plugin is welcome!

@wooorm wooorm closed this Sep 25, 2024
@wooorm wooorm added the 🤷 no/invalid This cannot be acted upon label Sep 25, 2024

This comment has been minimized.

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on
Development

Successfully merging this pull request may close these issues.

2 participants