Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace HTTPS with HTTP protocol for butler download URL #213

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

remarkablemark
Copy link
Member

What is the motivation for this pull request?

fix: replace HTTPS with HTTP protocol for butler download URL

See itchio/butler#265

What is the current behavior?

Butler download fails with:

Redirect from HTTPS to HTTP protocol. This downgrade is not allowed for security reasons. If you want to allow this behavior, set the allowRedirectDowngrade option to true.

What is the new behavior?

Butler download URL uses HTTP protocol to fix redirect error in GitHub Actions CI

Checklist:

```
Redirect from HTTPS to HTTP protocol. This downgrade is not allowed for
security reasons. If you want to allow this behavior, set the
allowRedirectDowngrade option to true.
```

See itchio/butler#265
@remarkablemark remarkablemark added the bug Something isn't working label Dec 16, 2024
@remarkablemark remarkablemark self-assigned this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (333d70a) to head (c62074d).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #213   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           44        44           
  Branches         8         8           
=========================================
  Hits            44        44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remarkablemark remarkablemark merged commit c754f65 into master Dec 16, 2024
29 checks passed
@remarkablemark remarkablemark deleted the fix/utils branch December 16, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant