update preset-env config to fix async tests #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowills
changed the title
peripateticus
approved these changes
Oct 9, 2020
|
Thank you, @cowills! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://git.rei.com/projects/FEDCOMP/repos/autocomplete/browse/test/AutocompleteInput.vue.spec.js#68
I noticed while updating the autocomplete component that Vunit 3.0.0 was throwing a
RegeneratorRuntime is not definederror on any tests that useasync.The error was not happening on Vunit 2.1.4, and I traced it down to the preset-env being passed into the babel-loader
2.1.4...v3.0.0
Tests work fine again if i either delete preset-env, or add in this config to make it target the currently installed version of node.
https://github.com/rei/rei-cedar/blob/next/babel.config.js#L12-L15 Cedar is also doing the "target current node" strategy.