Release/v15 #160

benjag · 2023-12-02T02:00:59Z

Release branch for 15.0.0. Individual features should PR against this branch.

Removes multiple props, the media container pattern, and simplifies markup BREAKING CHANGE: API has drastically changed as well as underlying markup of the component

Img refactor

Fluid presets

ACS-3918 - v15 modal teleport

…import them

…ndingLead to top-level

…nents

Refactoring style and lead

KenjiCrosland · 2024-01-24T21:25:09Z

src/components/choreographer/CdrChoreographer.vue

@@ -0,0 +1,50 @@
+<script setup lang="ts">


I didn't realize we were including this in v15?

Not exported. Leaving it in for further experimentation

I think the idea is we are not speaking about it

mhewson · 2024-01-24T21:46:21Z

public/cdr-reset.css

@@ -2,12 +2,7 @@ html {
  -webkit-box-sizing: border-box;
  box-sizing: border-box;
  font-family: sans-serif;
-  font-size: 10px; /* update postcss.config.js pxtorem if this changes */


also some future thoughts https://www.youtube.com/watch?v=cCAtD_BAHNw

mhewson · 2024-01-24T21:51:34Z

src/components/abstract/CdrAbstract.vue

+  </component>
+</template>
+
+<style lang="scss" module src="./styles/CdrAbstract.module.scss">


will these also be available in our component variables project?

No, not at this time. We'd have to figure out providing/exporting the fluid scale to that project

mhewson · 2024-01-24T21:58:39Z

src/components/abstract/styles/CdrAbstract.module.scss

+@import '../../../styles/settings/index.scss';
+@import '../../../styles/settings/fluid.vars.scss';
+
+.cdr-abstract {


the tag itself could have a few additional styles I should think

or maybe this is just a global p tag reset

like

max-width: 75ch; text-wrap: pretty;

mhewson · 2024-01-24T22:03:20Z

src/components/choreographer/CdrChoreographer.vue

@@ -0,0 +1,50 @@
+<script setup lang="ts">


I think the idea is we are not speaking about it

mhewson · 2024-01-24T22:04:13Z

src/components/image/CdrImg.vue

-    default: '',
-  },
-  /**
-   * Aspect ratio of the media container


mhewson · 2024-01-24T22:08:25Z

src/components/kicker/styles/CdrKicker.module.scss

+@import '../../../styles/settings/index.scss';
+@import '../../../styles/settings/fluid.vars.scss';
+
+.cdr-kicker {


text-wrap: nowrap ?

mhewson · 2024-01-24T22:15:07Z

src/components/landingLead/styles/CdrHeadingSubheadingBlock.module.scss

+@import '../../../styles/settings/index.scss';
+@import '../../text/presets/styles/CdrHeadingDisplay.module.scss';
+@import '../../text/presets/styles/CdrSubheadingSans.module.scss';
+


lets give our headings and titles
text-wrap: balance;

mhewson · 2024-01-24T22:17:49Z

src/components/modal/CdrModal.vue

-        :class="[style['cdr-modal__overlay'], overlayClass]"
-      />
-      <!-- This div (and the one below) is used to avoid a screen reader "keyboard" trap where the
+  <Teleport to="body">


do we need a note for why teleport? I mean I guess its just native Vue...

mhewson · 2024-01-24T22:21:36Z

src/components/picture/__tests__/CdrPicture.spec.js

+describe('CdrPicture', () => {
+  it('matches snapshot', () => {
+    const wrapper = shallowMount(CdrPicture, {
+      props: {


thoughts on how palette could change the image source? Atlassian has and interesting take
https://atlassian.design/components/image/examples#dark-mode

mhewson · 2024-01-24T22:27:53Z

src/components/text/presets/styles/CdrHeadingDisplay.module.scss

@@ -0,0 +1,8 @@
+@import './CdrPresets.module.scss';
+


lets add
text-wrap: balance;
to our headings

…body

benjag · 2024-01-24T23:25:39Z

src/components/text/styles/CdrText.module.scss

@@ -2,6 +2,5 @@
 @import './vars/CdrText.vars.scss';

 .cdr-text {
-  @include cdr-text-default;


mhewson · 2024-01-24T23:47:01Z

public/cdr-reset.css

@@ -38,6 +38,14 @@ body {
  background-color: #ffffff;
 }

+h1,h2,h3,h4,h5,h6 {
+  text-wrap: balance;


mhewson · 2024-01-24T23:47:14Z

public/cdr-reset.css

+  text-wrap: balance;
+}
+
+p {


benjag and others added 30 commits September 11, 2023 13:14

feat(lead): add static lead

eee6e22

feat: add fluid text presets and heading subheading composition block

edf74f7

chore(lead): merge lead work

2072857

feat(fluid): adds fluid preset and heading subheading composition

6147784

update to cqw

be5c993

test(lead): update snapshot

94d84f1

feat(box): wIP of CdrBox

526011a

ACS-3918 - v15 modal teleport

7173501

feat(text): add preset text components

804de33

feat(abstract): add abstract

9bf5964

feat(title): add title

ae0700d

feat(fluid): add fluid types scales

934275e

Revert adding box

421bf71

feat(choreographer): wIP of CdrChoreographer

136ad8f

Fluid updates

9b87d38

test(lead): update snapshots

ae72030

Fix casing on import path

67dc3f8

refactor(image): refactors CdrImg to use native CSS image properties

550b413

Removes multiple props, the media container pattern, and simplifies markup BREAKING CHANGE: API has drastically changed as well as underlying markup of the component

chore(deps): update chromedriver

d4ace05

Merge pull request #156 from rei/img-refactor

f51a430

Img refactor

refactor(lead): move block within lead component for now

7cc2e96

build: clean up exports

6ba712e

fix(fluid): move line height ratios outside of supports query

13a0cf4

test: add basic snapshot tests

86d51c2

chore: fix test pathing

d1dcbf1

Merge pull request #157 from rei/fluid-presets

b8f4705

Fluid presets

Merge pull request #154 from rei/pr/v15-modal-teleport-ACS-3918

e36245d

ACS-3918 - v15 modal teleport

chore: drop preset naming convention

9882e70

revert(card): revert card example removal

984a153

cleanup

8848f72

benjag added 18 commits January 16, 2024 13:53

15.0.0-beat.1

7124783

refactor(presets): externalize style modules so other components can …

07a956b

…import them

refactor(leads): refactors CdrLead in to CdrSplitSurface and moves La…

b63cf5a

…ndingLead to top-level

docs(docgen): adds @uses tag for components that use other core compo…

b13dcf2

…nents

test(landinglead): update snapshot to account for baseClass addition

246d490

style(eslint): adjust esline rules

b7f02d0

docs(docgen): replace with CdrIcon

148e8ce

Merge pull request #177 from rei/refactoring-style-and-lead

5d9896d

Refactoring style and lead

fix(landinglead): replace object-fit with custom property

db2bec0

docs(landinglead): reorder usage data

9d8e9bf

15.0.0-beta.2

c061c95

fix(toast): fix CSS display inheritance

8c440ff

docs(splitsurface): rewrite component description

f0d46e6

docs(quote): ignore modifier prop for demo

cab6ba0

feat(splitsurface): adds tag prop to allow elements other than div

dc8f19a

feat(tooltip): allow tooltip to generate a unique ID if none is provided

cb540d5

fix(tooltip): fix typeerror

bccfff9

docs: copy edits to component profiles

24922ee

benjag marked this pull request as ready for review January 24, 2024 20:37

benjag requested review from mhewson and KenjiCrosland January 24, 2024 20:37

KenjiCrosland reviewed Jan 24, 2024

View reviewed changes

mhewson approved these changes Jan 24, 2024

View reviewed changes

feat(text): add text-wrapping to reset and max-width to abstract and …

980bc50

…body

benjag commented Jan 24, 2024

View reviewed changes

KenjiCrosland approved these changes Jan 24, 2024

View reviewed changes

15.0.0

5641631

benjag merged commit 06a738d into main Jan 24, 2024
1 check passed

benjag deleted the release/v15 branch January 24, 2024 23:40

mhewson reviewed Jan 24, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release/v15 #160

Release/v15 #160

benjag commented Dec 2, 2023 •

edited

Loading

KenjiCrosland Jan 24, 2024

benjag Jan 24, 2024

mhewson Jan 24, 2024

mhewson Jan 24, 2024

mhewson Jan 24, 2024

mhewson Jan 24, 2024

benjag Jan 24, 2024

mhewson Jan 24, 2024

mhewson Jan 24, 2024

mhewson Jan 24, 2024

mhewson Jan 24, 2024

mhewson Jan 24, 2024

mhewson Jan 24, 2024

mhewson Jan 24, 2024

mhewson Jan 24, 2024

benjag Jan 24, 2024

mhewson Jan 24, 2024

mhewson Jan 24, 2024

Release/v15 #160

Release/v15 #160

Conversation

benjag commented Dec 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benjag commented Dec 2, 2023 •

edited

Loading