Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate type tests to Vitest #367

Merged
merged 43 commits into from
Jul 12, 2024
Merged

Migrate type tests to Vitest #367

merged 43 commits into from
Jul 12, 2024

Conversation

aryaemami59
Copy link
Contributor

This PR:

  • Converts typetest.ts file extensions to test-d.ts to be compatible with Vitest.
  • Converts expectType() to either assertType() or expectTypeOf().toMatchTypeOf().
  • Converts expectExactType to expectTypeOf().toEqualTypeOf().
  • Converts lone-blocks to test or describe blocks.

@aryaemami59
Bump Vitest
3843506
@aryaemami59
Bump typescript
fd2b480
@aryaemami59
Rename vitest.config.ts to vitest.config.mts
3bc821a
@aryaemami59
Remove typescript_test\typescript_extended\tsconfig.json
c308b50
@aryaemami59
Remove deps.interopDefault: true as it is the default
24ae054
@aryaemami59
Fix NPM scripts
950ca91
@aryaemami59
Include type checking with Vitest
2fe062c
@aryaemami59
Fix aliases in vitest.config.mts
3e044e8
@aryaemami59
Rename typescript_test/tsconfig.json to tsconfig.test.json
ad7af30
@aryaemami59
Remove tsconfig.json from test folder
e2d6d5f
@aryaemami59
Add tsconfig.base.json file
0e8aaae
@aryaemami59
Add tsconfig.build.json file
c6e0b85
@aryaemami59
Fix tsconfig.test.json
0dea0e2
@aryaemami59
Fix tsconfig.json file
dc2dcb5
@aryaemami59
Fix tsup.config.ts file
d4e428d
@aryaemami59
Change test:typescript to type-tests to stay consistent with RTK
e7b3abf
@aryaemami59
Add @types/node to dev dependencies
a63138d
@aryaemami59
Rename test.ts to index.test.ts
71b0bab
@aryaemami59
Rename typescript.ts to index.test-d.ts
52430e2
@aryaemami59
Convert some of the type tests to Vitest
2c71c6a
@aryaemami59
Fix type issues in JS files
a4e0bd8
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Feb 24, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@aryaemami59 aryaemami59 marked this pull request as ready for review February 24, 2024 13:31
@aryaemami59 aryaemami59 force-pushed the migrate-typetests-to-vitest branch 3 times, most recently from 038616e to 76e3cc6 Compare June 24, 2024 21:51
@aryaemami59
Fix CI tests
f51b119 
- It seems like the new version of Vite much like Node.js allows packages to self-reference themselves, which became a problem considering how we were running the tests against the build artifact during CI.
@aryaemami59 aryaemami59 force-pushed the migrate-typetests-to-vitest branch from 76e3cc6 to f51b119 Compare June 24, 2024 21:57
@aryaemami59
Copy link
Contributor Author

Had forgotten this still had some type tests that needed to be migrated to Vitest, all done now.

@timdorr
Copy link
Member

timdorr commented Jul 12, 2024

Looks great! Let's get it merged in.

@timdorr timdorr merged commit bf04cf7 into reduxjs:master Jul 12, 2024
20 checks passed
@aryaemami59
Copy link
Contributor Author

Thank you!!!!

@aryaemami59 aryaemami59 deleted the migrate-typetests-to-vitest branch July 12, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryaemami59 @timdorr