-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StreamingCredentialProvider support #3445
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladvildanov
force-pushed
the
vv-tba-support
branch
from
December 10, 2024 14:31
cbed9dc
to
24714ae
Compare
uglide
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zs-neo
pushed a commit
to zs-neo/redis-py
that referenced
this pull request
Dec 24, 2024
* Added StreamingCredentialProvider interface * StreamingCredentialProvider support * Removed debug statement * Changed an approach to handle multiple connection pools * Added support for RedisCluster * Added dispatching of custom connection pool * Extended CredentialProvider interface with async API * Changed method implementation * Added support for async API * Removed unused lock * Added async API * Added support for single connection client * Added core functionality * Revert debug call * Added package to setup.py * Added handling of in-use connections * Added testing * Changed fixture name * Added marker * Marked tests with correct annotations * Added better cancelation handling * Removed another annotation * Added support for async cluster * Added pipeline tests * Added support for Pub/Sub * Added support for Pub/Sub in cluster * Added an option to parse endpoint from endpoints.json * Updated package names and ENV variables * Moved SSL certificates code into context of class * Fixed fixtures for async * Fixed test * Added better endpoitns handling * Changed variable names * Added logging * Fixed broken tests * Added TODO for SSL tests * Added error propagation to main thread * Added single connection lock * Codestyle fixes * Added missing methods * Removed wrong annotation * Fixed tests * Codestyle fix * Updated EventListener instantiation inside of class * Fixed variable name * Fixed variable names * Fixed variable name * Added EventException * Codestyle fix * Removed redundant code * Codestyle fix * Updated test case * Fixed tests * Fixed test * Removed dependency
zs-neo
pushed a commit
to zs-neo/redis-py
that referenced
this pull request
Dec 24, 2024
* Added StreamingCredentialProvider interface * StreamingCredentialProvider support * Removed debug statement * Changed an approach to handle multiple connection pools * Added support for RedisCluster * Added dispatching of custom connection pool * Extended CredentialProvider interface with async API * Changed method implementation * Added support for async API * Removed unused lock * Added async API * Added support for single connection client * Added core functionality * Revert debug call * Added package to setup.py * Added handling of in-use connections * Added testing * Changed fixture name * Added marker * Marked tests with correct annotations * Added better cancelation handling * Removed another annotation * Added support for async cluster * Added pipeline tests * Added support for Pub/Sub * Added support for Pub/Sub in cluster * Added an option to parse endpoint from endpoints.json * Updated package names and ENV variables * Moved SSL certificates code into context of class * Fixed fixtures for async * Fixed test * Added better endpoitns handling * Changed variable names * Added logging * Fixed broken tests * Added TODO for SSL tests * Added error propagation to main thread * Added single connection lock * Codestyle fixes * Added missing methods * Removed wrong annotation * Fixed tests * Codestyle fix * Updated EventListener instantiation inside of class * Fixed variable name * Fixed variable names * Fixed variable name * Added EventException * Codestyle fix * Removed redundant code * Codestyle fix * Updated test case * Fixed tests * Fixed test * Removed dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.