-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Redis URI #208
base: master
Are you sure you want to change the base?
Support Redis URI #208
Conversation
@shacharPash This PR should include a couple of examples, specifically in the readme, for ease of connection, like other redis-clients |
// TODO: add tests | ||
|
||
[SkipIfRedis(Is.OSSCluster, Comparison.LessThan, "7.1.242")] | ||
public void TestDefaultLibName() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO this should be RedisUriParserTests, to align with the other class. Simlarly, let's add a mass coverage matrix. Can something like this work?
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 94.10% 93.93% -0.18%
==========================================
Files 85 88 +3
Lines 5178 5276 +98
Branches 487 494 +7
==========================================
+ Hits 4873 4956 +83
- Misses 178 188 +10
- Partials 127 132 +5 ☔ View full report in Codecov by Sentry. |
Closes #202
Closes #204