Updates to onprem OCP deployment #572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radez
force-pushed
the
ai_type_podman
branch
from
0cc0958 to
013e415
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: radez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
radez
changed the title
radez
force-pushed
the
ai_type_podman
branch
from
013e415 to
59a378a
Compare
akrzos
requested changes
Nov 22, 2024
ansible/roles/bastion-assisted-installer/templates/onprem-environment.j2
Show resolved
Hide resolved
radez
force-pushed
the
ai_type_podman
branch
2 times, most recently
from
ca80717 to
9ae43a9
Compare
|
I've been running with these changes on my env for a while. I think these are general changes we can make. I'd be great if some other folks could run these changes and verify they're ok. |
- Specify Podman as the deploy type for the bastion AI container example podman configmap: https://github.com/openshift/assisted-service/blob/master/deploy/podman/configmap.yml - no need to patch the cluster network settings after boot All the same settings are defined at cluster creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify Podman as the deploy type for the bastion AI container
example podman configmap: https://github.com/openshift/assisted-service/blob/master/deploy/podman/configmap.yml