-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump gulp from 4.0.2 to 5.0.0 #713
Conversation
d73cc47
to
981412b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks our gulp scripts, which are mainly used to compile the java code when bundling the server and jdt.ls extensions into the vscode extension.
We'll need to manually adapt our Gulp scripts if we wish to migrate to version 5. However, they have yet to update their documentation as to what's changed.
This is due to 1. a bug in our gulp script and 2. an upstream gulp bug/behaviour change: https://github.com/gulpjs/gulp/issues/2794
56a3c94
to
c156e72
Compare
Bumps [gulp](https://github.com/gulpjs/gulp) from 4.0.2 to 5.0.0. - [Release notes](https://github.com/gulpjs/gulp/releases) - [Changelog](https://github.com/gulpjs/gulp/blob/master/CHANGELOG.md) - [Commits](gulpjs/gulp@v4.0.2...v5.0.0) --- updated-dependencies: - dependency-name: gulp dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
c156e72
to
e81ab85
Compare
… exist Signed-off-by: David Thompson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made changes to the gulpfile to fix the bug in it, so it works now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me, and npm audit
is clean. I did notice :
WARNING in ./node_modules/follow-redirects/debug.js 7:14-30
Module not found: Error: Can't resolve 'debug' in '/home/rgrunber/git/vscode-quarkus/node_modules/follow-redirects'
Did you mean './debug'?
Requests that should resolve in the current directory need to start with './'.
Requests that start with a name are treated as module requests and resolve within module directories (node_modules).
If changing the source code is not an option there is also a resolve options called 'preferRelative' which tries to resolve these kind of requests in the current directory too.
@ ./node_modules/follow-redirects/index.js 7:12-30
@ ./node_modules/axios/dist/node/axios.cjs 10:24-51
@ ./src/utils/requestUtils.ts 28:16-32
@ ./src/wizards/generateProject/generationWizard.ts 25:23-58
@ ./src/commands/registerCommands.ts 22:27-81
@ ./src/extension.ts 31:27-65
WARNING in ./node_modules/vscode-languageserver-types/lib/umd/main.js 3:24-31
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
@ ./node_modules/vscode-languageserver-protocol/lib/common/api.js 23:13-51
@ ./node_modules/vscode-languageserver-protocol/lib/node/main.js 24:13-37
@ ./node_modules/vscode-languageclient/lib/common/api.js 22:13-54
@ ./node_modules/vscode-languageclient/lib/node/main.js 34:13-37
@ ./src/qute/languageServer/client.ts 14:32-64
@ ./src/extension.ts 35:17-56
but the follow-redirects warning was mentioned upstream and then was closed for other reasons.
If those aren't an issue feel free to merge.
Bumps gulp from 4.0.2 to 5.0.0.
Release notes
Sourced from gulp's releases.
... (truncated)
Changelog
Sourced from gulp's changelog.
... (truncated)
Commits
5c4c547
chore: Release 5.0.0 (#2762)bf72116
chore: Add index.mjs to files listb00de68
feat: Provide an ESM export (#2760)72668c6
chore!: Normalize repository, dropping node <10.13 support (#2758)85896d4
chore(docs): Update stream handbook link (#2711)818bd73
Docs: Remove gulp-sourcemaps because it is built-in (#2592)598f971
Docs: Fix broken link in recipe (#2571)9877de0
Docs: Guide CustomRegistries to maintain properties on tasks (fixes #2561) (#...f91c388
Docs: Remove typo in custom registry docs (#2543)df25250
Docs: Fix typo in task docs (#2524)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)