Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added start Ollama button and it functionality #158

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

msivasubramaniaan
Copy link

This PR shows Start Ollama button when Ollama server was stopped. When user clicks the button it starts the server on terminal

add-start-ollama-btn

@fbricon
Copy link
Collaborator

fbricon commented Nov 26, 2024

@msivasubramaniaan can you fix the conflicts please

@msivasubramaniaan
Copy link
Author

@msivasubramaniaan can you fix the conflicts please

Done

@fbricon
Copy link
Collaborator

fbricon commented Nov 26, 2024

So I like the idea, but I'm not fond of the current implementation:
The command spawns a process that will die when closing vscode, it might be a good, or a bad thing. But I tend to prefer starting a service/daemon instead.

The problem with starting ollama as a daemon is, there's no universal way to do it:

  • on Mac, running "ollama list" works (this is what is done after the brew installation)
  • on Linux, the "ollama list" trick doesn't work, so you need to try starting the ollama service first, then fall back to launching ollama serve in the background. See the ollama_start.sh script called on linux after installation
  • on Windows, I don't recall if the "ollama list" trick works. If it doesn't, we'd need to find a way to start the ollama service, and fall back to something like ollama serve >nul 2>&1

@fbricon
Copy link
Collaborator

fbricon commented Nov 26, 2024

no merge commits please, use rebase instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants