Skip to content

Commit

Permalink
fix(orchestrator):improve workflow details card in workflow page (#220)
Browse files Browse the repository at this point in the history
* fix(orchestrator):improve workflow details card in workflwo page

Signed-off-by: Lior Soffer <[email protected]>

* remove grid tag

Signed-off-by: Lior Soffer <[email protected]>

* fix

Signed-off-by: Lior Soffer <[email protected]>

---------

Signed-off-by: Lior Soffer <[email protected]>
Co-authored-by: Lior Soffer <[email protected]>
  • Loading branch information
LiorSoffer and Lior Soffer authored Dec 24, 2024
1 parent 9cc8c89 commit a75cfff
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 12 deletions.
5 changes: 5 additions & 0 deletions workspaces/orchestrator/.changeset/big-needles-grin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@red-hat-developer-hub/backstage-plugin-orchestrator': patch
---

improve workflow details card in workflow page
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const WorkflowDefinitionDetailsCard = ({
const details = React.useMemo(
() => [
{
label: 'type',
label: 'category',
value: formattedWorkflowOverview?.category,
},

Expand Down Expand Up @@ -87,17 +87,15 @@ const WorkflowDefinitionDetailsCard = ({
return (
<InfoCard title="Details" className={classes.details}>
<Grid container spacing={3} alignContent="flex-start">
<Grid container item md={4} spacing={3} alignContent="flex-start">
{details?.map(({ label, value, children }) => (
<Grid item md={6} key={label}>
{/* AboutField requires the value to be defined as a prop as well */}
<AboutField label={label} value={value}>
{loading ? <Skeleton variant="text" /> : children || value}
</AboutField>
</Grid>
))}
</Grid>
<Grid item md={8}>
{details?.map(({ label, value, children }) => (
<Grid item md={3} key={label}>
{/* AboutField requires the value to be defined as a prop as well */}
<AboutField label={label} value={value}>
{loading ? <Skeleton variant="text" /> : children || value}
</AboutField>
</Grid>
))}
<Grid item md={3}>
<AboutField
label="description"
value={formattedWorkflowOverview?.description}
Expand Down

0 comments on commit a75cfff

Please sign in to comment.