Update to Go 1.21 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
/lgtm |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chetan-rns, jopit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
deepsm007
reviewed
Jul 11, 2024
openshift-ci/build-root/Dockerfile
Outdated
| @@ -1,5 +1,5 @@ | |||
| # Dockerfile to bootstrap build and test in openshift-ci | |||
|
|
|||
| FROM registry.ci.openshift.org/openshift/release:golang-1.20 | |||
| FROM registry.ci.openshift.org/openshift/release:golang-1.21 | |||
|
|
|||
| RUN yum -y install dnf httpd-tools | |||
There was a problem hiding this comment.
If not required, you can remove this. yum seems to be the problem here
There was a problem hiding this comment.
@jgwest - can you remove the yum command as pointed by @deepsm007 ? It worked for us for gitops-operator redhat-developer/gitops-operator#743
jgwest
force-pushed
the
update-to-go-1-21-may-2024
branch
from
edeb811 to
f65b4bb
Compare
jgwest
force-pushed
the
update-to-go-1-21-may-2024
branch
from
f65b4bb to
4fc244f
Compare
Signed-off-by: Jonathan West <[email protected]>
jgwest
force-pushed
the
update-to-go-1-21-may-2024
branch
from
4fc244f to
bd9e09d
Compare
|
/retest |
|
/lgtm |
openshift-merge-bot
bot
merged commit 1ae431a
into
redhat-developer:master
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Update to Go v1.21