Handle finalizer removal #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
|
johnmcollier
commented
May 9, 2024
| @@ -86,6 +90,25 @@ func (r *ApplicationReconciler) Reconcile(ctx context.Context, req ctrl.Request) | |||
| return reconcile.Result{}, err | |||
| } | |||
|
|
|||
| // If the resource still has the finalizer attached to it, just remove it so deletion doesn't get blocked | |||
| if containsString(application.GetFinalizers(), appFinalizerName) { | |||
There was a problem hiding this comment.
I had copied the code back to how we initially did it, which didn't use string.Contains.
I can't remember why we didn't use it, but would prefer we leave the original code as-is
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Updates the Application and Component controllers to add back the finalizer removal code. Upon each reconcile of a resource, the controllers will check if the resource still has the finalizer present, and if so, removes it before completing reconciliation. This will also ensure that no resources have finalizers left when HAS is deprecated.
Which issue(s)/story(ies) does this PR fixes:
N/A, but relates to https://issues.redhat.com/browse/DEVHAS-648
PR acceptance criteria:
Unit/Functional tests
Documentation
Client Impact
How to test changes / Special notes to the reviewer: