Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sonar cloud properties #422

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

sawood14012
Copy link

@sawood14012 sawood14012 commented Nov 29, 2023

What does this PR do?:

This commit Adds sonar cloud properties for better control.

Which issue(s)/story(ies) does this PR fixes:

https://issues.redhat.com/browse/DEVHAS-551

PR acceptance criteria:

  • Unit/Functional tests

  • Documentation

  • Client Impact

How to test changes / Special notes to the reviewer:

This commit Adds sonar cloud properties for better control.

Signed-off-by: Meer Sawood <[email protected]>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72c41a8) 81.34% compared to head (88ccacf) 81.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   81.34%   81.34%           
=======================================
  Files          32       32           
  Lines        4788     4788           
=======================================
  Hits         3895     3895           
  Misses        702      702           
  Partials      191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm as the sonar cloud check is passing :)

Copy link

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sawood14012, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sawood14012 sawood14012 merged commit 46ad293 into redhat-appstudio:main Nov 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants