revert changes for RHTAPBUGS-12 (#425)

* revert changes for RHTAPBUGS-12 Signed-off-by: Kim Tsao <[email protected]> * revert changes for RHTAPBUGS-12- remove dup attribute Signed-off-by: Kim Tsao <[email protected]> --------- Signed-off-by: Kim Tsao <[email protected]>
redhat-appstudio · Dec 4, 2023 · 5c90c13 · 5c90c13
1 parent d506e22
commit 5c90c13
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/pkg/devfile/devfile.go b/pkg/devfile/devfile.go
@@ -166,7 +166,9 @@ func GetResourceFromDevfile(log logr.Logger, devfileData data.DevfileData, deplo
 						resources.Deployments[0].Spec.Template.ObjectMeta.Labels = matchLabels
 					}
 
-					resources.Deployments[0].Spec.Replicas = &currentReplica
+					if currentReplica > 0 {
+						resources.Deployments[0].Spec.Replicas = &currentReplica
+					}
 
 					if len(resources.Deployments[0].Spec.Template.Spec.Containers) > 0 {
 						if image != "" {

diff --git a/pkg/devfile/devfile_test.go b/pkg/devfile/devfile_test.go
@@ -1210,7 +1210,6 @@ components:
     deployment/container-port: 1111
     deployment/storageLimit: 401Mi
     deployment/storageRequest: 201Mi
-    deployment/replicas: 1
   kubernetes:
     deployByDefault: false
     endpoints:
@@ -1308,7 +1307,6 @@ components:
     deployment/container-port: 1111
     deployment/storageLimit: 401Mi
     deployment/storageRequest: 201Mi
-    deployment/replicas: 1
   kubernetes:
     deployByDefault: false
     endpoints:
@@ -1423,7 +1421,6 @@ components:
     deployment/container-port: 1111
     deployment/storageLimit: 401Mi
     deployment/storageRequest: 201Mi
-    deployment/replicas: 1
   kubernetes:
     deployByDefault: false
     endpoints:
@@ -1533,7 +1530,6 @@ components:
 - attributes:
     api.devfile.io/k8sLikeComponent-originalURI: deploy.yaml
     deployment/container-port: 5566
-    deployment/replicas: 1
   kubernetes:
     deployByDefault: false
     endpoints: