Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump baasaas version #8022

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Bump baasaas version #8022

merged 1 commit into from
Sep 9, 2024

Conversation

jbreams
Copy link
Contributor

@jbreams jbreams commented Sep 9, 2024

What, How & Why?

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@jbreams jbreams requested a review from mpobrien September 9, 2024 03:02
@cla-bot cla-bot bot added the cla: yes label Sep 9, 2024
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build jonathan.reams_3415

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 71 unchanged lines in 20 files lost coverage.
  • Overall coverage increased (+0.002%) to 91.11%
Files with Coverage Reduction New Missed Lines %
src/realm/mixed.cpp 1 86.9%
src/realm/query_expression.hpp 1 93.81%
src/realm/sync/noinst/client_impl_base.cpp 1 82.78%
src/realm/sync/noinst/server/server.cpp 1 74.21%
src/realm/sync/noinst/server/server_history.cpp 1 62.92%
src/realm/util/serializer.cpp 1 90.43%
src/realm/uuid.cpp 1 98.48%
test/fuzz_tester.hpp 1 57.73%
test/test_dictionary.cpp 1 99.83%
src/realm/array_blobs_big.cpp 2 98.58%
Totals Coverage Status
Change from base Build 2602: 0.002%
Covered Lines: 217197
Relevant Lines: 238389
💛 - Coveralls

michael-wb
michael-wb approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@michael-wb michael-wb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for updating - I noticed the tests started to fail today because of baasaas.

@jedelbo jedelbo merged commit fd63c1c into master Sep 9, 2024
45 of 49 checks passed
@jedelbo jedelbo deleted the jbr/bump_baas_again branch September 9, 2024 11:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michael-wb michael-wb michael-wb approved these changes

@mpobrien mpobrien Awaiting requested review from mpobrien

Assignees

@jbreams jbreams

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbreams @michael-wb @jedelbo